Fix compatibility with Symfony 5.0

sampart / WhiteOctoberTCPDFBundle

A bundle to facilitate using TCPDF for PDF generation in Symfony applications

89 stars 43 forks source link

Fix compatibility with Symfony 5.0 #58

Closed davnavarro closed 4 years ago

sampart commented 4 years ago

Hi @davnavarro, thanks for contributing! I presume that this change doesn't work in older versions of Symfony? Do you know which versions it works with?

davnavarro commented 4 years ago

Hi @sampart, Please, give me some time and I check ;)

davnavarro commented 4 years ago

Hi @sampart, This change works (tested) in versions 4.3, 4.4 and 5.0 In previous versions I could not verify.

https://symfony.com/blog/new-in-symfony-4-2-important-deprecations

sampart commented 4 years ago

Many thanks for this. Looking at the link, this change will work in Symfony 3.3 and up. Therefore, we'd need to change composer.json as part of this (and make it a major version bump when releasing). Please could you either...

Update this PR to include the necessary changes to composer.json: "symfony/framework-bundle": ">=3.3", and "php": "^5.5.9|>=7.0.8"
Or, if you're feeling keen, this would be a great case for a maintained fork, so might you be interested in setting up a fork for sf 3.3 and above? (See linked issue for details)

davnavarro commented 4 years ago

Hi @sampart, I hadn't done this before ... Please, when you can check this: QipsiusTCPDFBundle Any help and guidance will be welcome.

sampart commented 4 years ago

Thanks so much for taking this on, @davnavarro - your fork looks great. I've added a note to the top of the README for this repo suggesting that people use your fork.

I recommend that you now look through the issues logged against this project and post a comment if any are resolved by your fork. This may also give you ideas as to what changes to make next in your onward development.

Thanks again for your work here.