search

sampart / cordova-plugin-app-version

Cordova plugin to return the version number of the current app [not maintained]
MIT License
401 stars 195 forks source link

add basic types #122

Closed szh closed 2 years ago

szh commented 3 years ago

I know this repo isn't being maintained, but I wanted to submit this PR so anybody else who needs type definitions will know they exist in my fork.

sampart commented 3 years ago

Hi @szh, thanks for getting involved. As you say, this repo isn't maintained any more, but if you're planning on maintaining your fork, would you be interested in becoming an "official" maintainer? What I'd do in that case is link to your fork from the README and then once you'd made a sufficient number of improvements, we could make your fork the "parent" and this repo would become a fork of yours. Would you be interested in that?

(In the interests of transparency, I'd probably also mention the other forks in the README, but would link to yours the most prominently.)

szh commented 3 years ago

@sampart At this time I don't think I have the time and resources to properly manage this project. If that changes I'll comment here.

sampart commented 3 years ago

No worries, thanks @szh. Although I'm not maintaining this myself, I'm happy to merge simple PRs. I've added some review comments. Thanks.

szh commented 2 years ago

This is clearly not being maintained anymore, and I'm no longer working with it either, so I'll close this PR. The fork and branch remain for anyone who wants to make use of it.