search

sampgo / cli

Command Line Interface (CLI) utility for sampgo.
0 stars 1 forks source link

Fix: Add compatibility with any shell #6

Open alextwothousand opened 3 years ago

alextwothousand commented 3 years ago

At the moment, we default to "sh" (for any non-windows OS) and "cmd" for Windows. We should look into determining what shell the current user executed sampgo cli from, then using that.

ImOver00 commented 3 years ago

I'd say we firstly would start with finding an ouput colouring library that is compatible with all shells (including Command Prompt, Old PS etc) because the current package we're using (Chalk) acts weird in those old terminals.

alextwothousand commented 3 years ago

replace urfave/cli and chalk with pTerm.

alextwothousand commented 3 years ago

Never mind, pTerm doesn't provide the functionality that urfave/cli does. But thats OK, we can just use pTerm instead of chalk-- it looks better anyway.

ImOver00 commented 3 years ago

We can use pTerm instead of Survey I think or otherwise we can use it for colouring and that's it.

alextwothousand commented 3 years ago

We can use pTerm instead of Survey I think or otherwise we can use it for colouring and that's it.

The power of cross collaboration :) You can give it a try in a separate branch and see if it works. IIRC pTerm would only be a replacement for chalk.