search

sampie777 / hymnbook2

Mobile hymn book app.
2 stars 0 forks source link

[feature] Ability to show search results sorted by song bundle #221

Closed sampie777 closed 5 months ago

sampie777 commented 5 months ago

Instead of sorting the song search results by relevance, give the option to sort them by bundle.

By the pastors.

sampie777 commented 5 months ago

A weird bug arose during development:

The title of the song bundle selection dialog didn't wrap correct. The text "Search only in the selected bundles" was wrapped to "Search only in the selected", removing the last word. One could see the top part of the last word rendering below the visible text, but the <Text> component did not resize so it all fits. I made an example project which reproduces this problem on a Google Pixel 7a: https://gist.github.com/sampie777/17d6560b6a07afdb29d140d98f8181fe A possible solution seems to not use flexGrow: 1 on the <Text> component, but use percentages on the minWidth and flexBasis properties. Not ideal, as the value for these percentages may differ from device to device. So we should need to keep an eye on that.