search

sampl / firefly

Web app boilerplate for beginners based on Firebase and React 🔥
http://getfirefly.org/
234 stars 42 forks source link

Scroll to top on route change #102

Closed sampl closed 5 years ago

sampl commented 6 years ago

https://reacttraining.com/react-router/web/guides/scroll-restoration

https://github.com/sampl/firefly/commit/c2d9aca6847333779f5ed655b61a2dda8bd2c17a

sampl commented 6 years ago

https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/docs/guides/scroll-restoration.md#scroll-to-top

This will break some apps that have tabs or push-state that doesn't always require a scroll to top. Don't include?

sampl commented 5 years ago

easier now that page transitions are gone?

sampl commented 5 years ago

done af7b20579dcbf3359760098bcd2c7f61e45100ea