search

sampl / firefly

Web app boilerplate for beginners based on Firebase and React 🔥
http://getfirefly.org/
234 stars 42 forks source link

Tsify - Functions #163

Open SamBroner opened 5 years ago

SamBroner commented 5 years ago

@sampl here's a rough draft of functions tsify-ed... Kind of interesting if you clone it.

You're gaining a type system. That comes with a few clear benefits for new devs: autocorrect, api discovery through intelli-sense.

I'll finish the rest at some point, but probably not today.

sampl commented 5 years ago

Just looked through this, very cool @SamBroner.

My current thinking is to not merge to master since it's a beginner boilerplate, though I'm open to reconsidering if I have a chance to dive into TS more myself.

If you decide to fork Firefly with TS, I'd be happy to link to it in the docs and readme.

SamBroner commented 5 years ago

Fair. I do encourage you to play around with the functions code. You may find discovery much easier. I'm finding myself evangelizing TypeScript, especially when helping devs who are coming from a typed world. (Devs used to zero compilation JS are a little less excited!)

Swapping over the view code seemed like unnecessary work in order to fulfill my own agenda. Hopefully someone else can take this idea and finish the rest.

sampl commented 5 years ago

Will definitely do next time I get the chance. Thanks Sam.