search

sampl / firefly

Web app boilerplate for beginners based on Firebase and React 🔥
http://getfirefly.org/
234 stars 42 forks source link

Updated firebase to avoid grpc error on npm install #168

Closed jnelson180 closed 5 years ago

jnelson180 commented 5 years ago

Before, if you ran npm install in the base directory while running Node V12, you'd get a breaking error because grpc was not compatible. Firebase versions 6.1.0 and higher resolve that incompatibility by using a higher version of grpc.

sampl commented 5 years ago

Not tested, but such a simple change (famous last words).

Sorry for the delay @jnelson180, thank you for contributing!

jnelson180 commented 5 years ago

Glad I could help!

Jake Nelson (608) 294-0171 https://jnelson180.github.io/ https://jnelson180.github.io/

On Mon, Jun 17, 2019 at 9:54 AM Sam Pierce Lolla notifications@github.com wrote:

Not tested, but such a simple change (famous last words).

Sorry for the delay @jnelson180 https://github.com/jnelson180, thank you for contributing!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sampl/firefly/pull/168?email_source=notifications&email_token=ADFFX3S47PZMROXSPWIP3PLP26QTLA5CNFSM4HVMFOE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3NZUY#issuecomment-502717651, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFFX3QKS6WTJTY576TL2T3P26QTLANCNFSM4HVMFOEQ .