search

sampl / firefly

Web app boilerplate for beginners based on Firebase and React 🔥
http://getfirefly.org/
234 stars 42 forks source link

posts _likeCount field not changing when user likes/dislikes a post #169

Closed tconroy closed 5 years ago

tconroy commented 5 years ago

hello. Just started playing around with this. Havent made any changes, just followed along with the docs.

When a post is liked, the postLike object is created, but the _likeCount field on the posts document does not change.

sampl commented 5 years ago

Hi, thanks for posting. Are your backend functions running? This is where the like count happens. IIRC there are some instructions in the readme for setting up the backend.

On Sat, Aug 31, 2019 at 3:32 PM Tom notifications@github.com wrote:

hello. Just started playing around with this. Havent made any changes, just followed along with the docs.

When a post is liked, the postLike object is created, but the _likeCount field on the posts document does not change.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sampl/firefly/issues/169?email_source=notifications&email_token=AABYTKYV44MSUWCBOK7XI63QHLBMPA5CNFSM4ISUTEV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HITJTVQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AABYTK6VY4A5AJ42KV3CGPLQHLBMPANCNFSM4ISUTEVQ .

tconroy commented 5 years ago

Thanks for the reply, @sampl!

I had forgotten to deploy the backend functions ( thanks for the reminder! ) however even once I did that I'm still not seeing the change.

Hopping into the functions section of firebase I noticed there is an error happening in updatePostLikeCount, Error: process.env.GCLOUD_PROJECT is not set.

is this something we're supposed to set in functions/.env.dev? I'm not seeing it in the docs anywhere.

Thanks!

tconroy commented 5 years ago

Oh, nevermind! I figured it out.

I had set 

  "engines": {
    "node": "10"
  },

in functions/package.json. However I read online this should be "node": "8". After changing that and redeploying the functions, Im seeing like count update!

Thanks for the help 👍

sampl commented 5 years ago

Glad it’s fixed!

Not sure why it’s not working in node 10 though, unless it’s just not supported by fire base yet?

On Sat, Aug 31, 2019 at 4:09 PM Tom notifications@github.com wrote:

Oh, nevermind! I figured it out.

I had set

"engines": {

"node": "10"

},

in functions/package.json. However I read online this should be "node": "8". After changing that and redeploying the functions, Im seeing like count update!

Thanks for the help 👍

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sampl/firefly/issues/169?email_source=notifications&email_token=AABYTK56NE4S6D3GPQPADADQHLFXDA5CNFSM4ISUTEV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TUMEA#issuecomment-526861840, or mute the thread https://github.com/notifications/unsubscribe-auth/AABYTK7M5RDD6RL6H2LEGCDQHLFXDANCNFSM4ISUTEVQ .

tconroy commented 5 years ago

I'm not entirely sure, but that sounds likely! It looks like the NodeJS 10 runtime is listed as pre-release in the cloud functions doc: https://cloud.google.com/functions/docs/concepts/nodejs-10-runtime