samplchallenges / SAMPL5_logD_PredictionAnalysis

Analysis of all predictions submitted for the distribution coefficient part of the SAMPL5 challenge
MIT License
2 stars 1 forks source link

Checklist for changes from informal reviews #18

Closed bannanc closed 6 years ago

bannanc commented 8 years ago

This is just for me to check off what still needs to be done, I think any of the discussion should happen inside their issues. Links available

I'm willing to put a prefix on that sentence with discussion with participants including Andreas Klamt... I know we were concerned about water before discussions with anyone because we had discussed it when analyzing my logP results. #10

I will mention the quantification of water in cyclohexane when I describe his method as the "winner" so that readers know they could read more about that in his paper. #10

davidlmobley commented 8 years ago

@bannanc - not sure I understand this point:

I'm willing to put a prefix on that sentence with discussion with participants including Andreas Klamt... I know we were concerned about water before discussions with anyone because we had discussed it when analyzing my logP results.

Can you clarify?

I will mention the quantification of water in cyclohexane when I describe his method as the "winner" so that readers know they could read more about that in his paper.

Do you have the PDF of his paper so you can check that it has the detail you're thinking of? If not let me know and I'll send it. (Actually, I think it's already out in JCAMD ASAP...)

Otherwise I think it looks good.

bannanc commented 8 years ago

@davidlmobley I think my point about mentioning Klamt, discussion with participants made more sense in the context of issue #10 but basically, he was arguing that he was the first one to suggest water in cyclohexane might be important, but I know we discussed it before talking to anyone in the challenge because we talked about it when discussing the logP paper. He wanted credit for the idea in our paper. I most just meant I would something like "After discussion with participants, including Andreas Klamt, ..." to the beginning of the discussion about the water in cyclohexane section, although, I believe we were concerned about this affect before talking to him.

Also, I'm adding a point above, I realized in table 5 and 6 I have sign errors on the solvation free energies, I forgot to reverse it so it is currently the free energy to remove the molecule from water instead of the free energy for solvation.

davidlmobley commented 8 years ago

I don't think we need to add anything to give him credit for something we talked about long before talking with him. We can certainly say that we also discussed it with him.

bannanc commented 8 years ago

Ok, I'll mention that we discussed it with him.

bannanc commented 8 years ago

I will mention the quantification of water in cyclohexane when I describe his method as the "winner" so that readers know they could read more about that in his paper. #10

I was under the assumptions from Klamt's comments that he included water in cyclohexane before the challenge, but I just skimmed through his paper and read the section on quantifying water in cyclohexane. They did not do this until AFTER they got their results so I'm not going to mention it in our paper.

davidlmobley commented 8 years ago

Sounds good.

bannanc commented 8 years ago

everything but last point is addressed in pull request #20

bannanc commented 6 years ago

Trying to organize my github, since this paper is already published I'm closing this issue.