search

samplchallenges / SAMPL5_logD_PredictionAnalysis

Analysis of all predictions submitted for the distribution coefficient part of the SAMPL5 challenge
MIT License
2 stars 1 forks source link

Final Changes #22

Closed bannanc closed 8 years ago

bannanc commented 8 years ago

I fixed some of the changes we discussed on the last pull request. There are more line by line comments on this pull request.

In the current commit I am still referencing Luchko's paper.

davidlmobley commented 8 years ago

I think this is good to go once you address the KHB issue and the wording I commented on above, if there are no other outstanding issues.

davidlmobley commented 8 years ago

Maybe just ping me on Slack when you finalize and merge, then I can try and submit? Hopefully I'll have time tomorrow. Nice work! Thanks!

bannanc commented 8 years ago

I removed KHB from the funding and updated the comment about simulation times and water. I haven't changed anything about the Luchko citation.