search

samply / bbmri-fhir-ig

This is the source for the BBMRI.de / GBA Implementation Guide.
https://samply.github.io/bbmri-fhir-ig/
Creative Commons Attribution Share Alike 4.0 International
6 stars 0 forks source link

Removed diagram from overview page #132

Closed DavidCroftDKFZ closed 1 year ago

DavidCroftDKFZ commented 1 year ago

This diagram has been flagged as confusing a number of times, so it is being removed from the overview page.

noemide commented 1 year ago

I believe the error message is actually correct. If i look here: https://github.com/samply/bbmri-fhir-ig/tree/master/input/resources There are JuridicalPerson.StructureDefinition.json and JuridicalPerson.StructureDefinition.json which i seem to have missed and therefore failed to delete during SUSHI migration. I believe that deleting these two files should fix the error.

DavidCroftDKFZ commented 1 year ago

Hi Noemi,

The two links that you mention seem to point to the same file! Is there a second file that I should also delete?

Regards,

David.

From: Noemi Deppenwiese @.***> Sent: Wednesday, February 1, 2023 5:39 PM To: samply/bbmri-fhir-ig Cc: Croft, David; Author Subject: Re: [samply/bbmri-fhir-ig] Removed diagram from overview page (PR #132)

I believe the error message is actually correct. If i look here: https://github.com/samply/bbmri-fhir-ig/tree/master/input/resources There are JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json and JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json which i seem to have missed and therefore failed to delete during SUSHI migration. I believe that deleting these two files should fix the error.

- Reply to this email directly, view it on GitHubhttps://github.com/samply/bbmri-fhir-ig/pull/132#issuecomment-1412366033, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALE7AZDPTOFAH7TUZDTCZOTWVKGVHANCNFSM6AAAAAAUMPAZY4. You are receiving this because you authored the thread.Message ID: @.***>

noemide commented 1 year ago

Hi Noemi, The two links that you mention seem to point to the same file! Is there a second file that I should also delete? Regards, David. … ____ From: Noemi Deppenwiese @.> Sent: Wednesday, February 1, 2023 5:39 PM To: samply/bbmri-fhir-ig Cc: Croft, David; Author Subject: Re: [samply/bbmri-fhir-ig] Removed diagram from overview page (PR #132) I believe the error message is actually correct. If i look here: https://github.com/samply/bbmri-fhir-ig/tree/master/input/resources There are JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json and JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json which i seem to have missed and therefore failed to delete during SUSHI migration. I believe that deleting these two files should fix the error. - Reply to this email directly, view it on GitHub<#132 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALE7AZDPTOFAH7TUZDTCZOTWVKGVHANCNFSM6AAAAAAUMPAZY4. You are receiving this because you authored the thread.Message ID: @.>

Sorry, copy-paste Error. Yes, ParentCollection.json should also be deleted to fix the error.

DavidCroftDKFZ commented 1 year ago

Thanks!

From: Noemi Deppenwiese @.***> Sent: Thursday, February 2, 2023 9:09 AM To: samply/bbmri-fhir-ig Cc: Croft, David; Author Subject: Re: [samply/bbmri-fhir-ig] Removed diagram from overview page (PR #132)

Hi Noemi, The two links that you mention seem to point to the same file! Is there a second file that I should also delete? Regards, David. ... ____ From: Noemi Deppenwiese @.> Sent: Wednesday, February 1, 2023 5:39 PM To: samply/bbmri-fhir-ig Cc: Croft, David; Author Subject: Re: [samply/bbmri-fhir-ig] Removed diagram from overview page (PR #132https://github.com/samply/bbmri-fhir-ig/pull/132) I believe the error message is actually correct. If i look here: https://github.com/samply/bbmri-fhir-ig/tree/master/input/resources There are JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json and JuridicalPerson.StructureDefinition.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/JuridicalPerson.StructureDefinition.json which i seem to have missed and therefore failed to delete during SUSHI migration. I believe that deleting these two files should fix the error. - Reply to this email directly, view it on GitHub<#132 (comment)https://github.com/samply/bbmri-fhir-ig/pull/132#issuecomment-1412366033>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALE7AZDPTOFAH7TUZDTCZOTWVKGVHANCNFSM6AAAAAAUMPAZY4. You are receiving this because you authored the thread.Message ID: @.>

Sorry, copy-paste Error. Yes, ParentCollection.jsonhttps://github.com/samply/bbmri-fhir-ig/blob/master/input/resources/ParentCollection.json should also be deleted to fix the error.

- Reply to this email directly, view it on GitHubhttps://github.com/samply/bbmri-fhir-ig/pull/132#issuecomment-1413307965, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALE7AZEFRHPBFXPTKMZZ6I3WVNTSRANCNFSM6AAAAAAUMPAZY4. You are receiving this because you authored the thread.Message ID: @.***>