samply / bbmri-fhir-ig

This is the source for the BBMRI.de / GBA Implementation Guide.
https://samply.github.io/bbmri-fhir-ig/
Creative Commons Attribution Share Alike 4.0 International
6 stars 0 forks source link

Fix Warning of Biobank.contact.purpose RESEARCH #84

Open alexanderkiel opened 4 years ago

alexanderkiel commented 4 years ago

For the value RESEARCH in purpose coding, we introduced our own code system https://fhir.bbmri.de/CodeSystem/ContactType. But somehow the validator doesn't like it, because the usual code system at this point is http://hl7.org/fhir/ValueSet/contactentity-type. The warning is:

Warning @ Organization.contact[1].purpose (line 111, col20) : 
  None of the codes provided are in the value set http://hl7.org/fhir/ValueSet/contactentity-type
  (http://hl7.org/fhir/ValueSet/contactentity-type), and a code should come from this value set
  unless it has no suitable code) 
  (codes = https://fhir.bbmri.de/CodeSystem/ContactType#RESEARCH)
noemide commented 4 years ago

Maybe we could supress this error somehow? The binding is extensible and the original ValueSet does not include a fitting code, so unsing our own code is vaild here.

alexanderkiel commented 4 years ago

I'm not sure if we have to somehow extend the binding explicitly. I only see that you defined the fix values of https://fhir.bbmri.de/CodeSystem/ContactType and RESEARCH in that slice. Btw. I would rename the slice from contact to research.

noemide commented 3 years ago

Making a binding wider in a derived profile is not possible. I'll see if we can supress the waring. If not, i will add a comment to the validation support page that warnings like this are to be expected.