search

sampointer / fluent-plugin-cloudwatch-ingest

Alternative to ryotarai/fluent-plugin-cloudwatch-logs for ingesting AWS Cloudwatch logs via fluentd
GNU General Public License v3.0
11 stars 10 forks source link

bail out of processing if fluentd stops + batch log stream processing… #12

Closed chicofranchico closed 7 years ago

chicofranchico commented 7 years ago

… (dont process all at once)

Sorry about the linting of RubyMine

sampointer commented 7 years ago

There seems to be a large number of unrelated formatting changes in this PR, which makes it quite difficult to understand what has changed functionally. Any chance you could make a cleaner changeset?

sampointer commented 7 years ago

For some reason circleci is not configured to build PRs. I'll look into this, but in the meantime I'd also appreciate if in addition to cleaning up the unrelated whitespace changes you could ensure the PR passes the linter: bundle exec rake rubocop.

chicofranchico commented 7 years ago

Sure, I'll cleanup the identation applied by default from RubyMine. There's one though from the main loop which is on purpose. I'll add my comments inline.

chicofranchico commented 7 years ago

There are only two rubocop inspections left, which I haven't touched.

sampointer commented 7 years ago

Apologies it has taken so long to get this merged.

At the minute I'm not in a good place to test this. Therefore I'm going to tag and publish it as 1.5.0.rc1 so that others can help with the testing easily.

To install pre-release versions of gems please see: http://guides.rubygems.org/patterns/#prerelease-gems

sampointer commented 7 years ago

What would help move the rc to a full release would be help in fixing some of the lint violations: https://circleci.com/gh/sampointer/fluent-plugin-cloudwatch-ingest

sampointer commented 7 years ago

Hey. It took some time to get the linter to pass this release. 1.5.0.rc2 is up on rubygems now for testing.

chicofranchico commented 7 years ago

Thanks for that. I could only get to it today. Much appreciated.