search

sampotter / fluxpy

Fast thermal modeling and radiosity in Python.
11 stars 5 forks source link

issue with new form_factors.py #56

Closed steo85it closed 2 years ago

steo85it commented 2 years ago

The issue seems to be with this row. If this is changed to indptr = [0], then the code doesn't crash, but it runs in what seems to be an infinite loop.

sampotter commented 2 years ago

Oops, thanks for catching that...

I pushed a change (c7381ccc87079d92c9aa2a9e22375f3eca57b37d) to do the equivalent of what you did but while keeping indptr as an array instead of changing it to a list.

This worked for me on pretty small test case. Trying on a little bit larger test now. (Using haworth.py to test for now.)

If the infinite loop behavior persists, let me know and we'll figure it out.

steo85it commented 2 years ago

It seems to work (and yes, my bad not spotting immediately how to solve it!), thanks! I'm relaunching the memory tests and let's see tomorrow morning.

sampotter commented 2 years ago

Thanks! No problem at all... I hadn't used this array class before either.