search

sampotter / python-embree

Apache License 2.0
20 stars 6 forks source link

Build Wheels In Github Actions #17

Closed mikedh closed 2 years ago

mikedh commented 2 years ago

Uses Embree releases to build wheels using cibuildwheel on Github actions, currently appears to be building and testing:

embree-0.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
embree-0.0.0-cp36-cp36m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
embree-0.0.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
embree-0.0.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
embree-0.0.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

Since Embree is so architecture specific, I think there's probably no point of even attempting Mac wheels. Windows looks doable... eventually haha. I don't know if you want to release this binding onto pypi, but it looks like embree, pyembree, embree3 are all available.

I also didn't do any additional testing of results or benchmarking against the prior bindings, as I was hesitant to investigate for https://github.com/mikedh/trimesh/pull/1108 until packaging was further along. Thanks for your work on this project!

sampotter commented 2 years ago

I'm kind of sidelined with other stuff right now. Is there anything specific here you think I should take a look at before merging, or should I just go for it? I trust your judgment.

Also, re: PyPI: happy to release on there. Not really sure what the process is. If by:

I don't know if you want to release this binding onto pypi, but it looks like embree, pyembree, embree3 are all available.

you mean whether I have a preference for the name, I think "python-embree" or "embree" would be the best options.

mikedh commented 2 years ago

No worries me too 😅. Yeah I think this is good to merge, although to release to PyPi you'll have to add a PYPI_TOKEN to the repo secrets. If you're comfortable adding me as an admin on this repo I can add a pypi token and then add you as an owner on PyPi.

you mean whether I have a preference for the name, I think "python-embree" or "embree" would be the best options.

Cool agreed, I think the default behavior is to release it to the package name in setup.py (embree) which works nicely.

sampotter commented 2 years ago

All right, sounds good.

I went ahead and invited you to be a collaborator on this project.

I definitely appreciate the help, thanks. :-)