search

sampottinger / co_opencampaigndata

API service for serving Colorado TRACER data for opencampaigndata.org
GNU General Public License v3.0
10 stars 1 forks source link

Added account_db_facade implementation. #16

Closed sampottinger closed 11 years ago

sampottinger commented 11 years ago

Fixes #11. Provides implementation of account_db_facade along with helper modules env_config for managing environment configuration settings. Some updates were made to unit tests. Code reviews welcome!

trinary commented 11 years ago

I think the PR is missing generic-pool? I don't see it anywhere and the tests require it.

trinary commented 11 years ago

This is a lot to go over, and honestly while I know a fair amount about JS itself as far as node+promise app architecture goes I'm no expert. What I see in this PR reads very well and is very consistent. If the connection-strategy/pool/request lifecycle is working I see no reason to object, the implementation looks very nice.

:+1:, I want to make sure we're not hung up here, all this stuff is changeable later, let's get to the public API!

trinary commented 11 years ago

Merge it!

sampottinger commented 11 years ago

Yea, I saw the jshint stuff. No objections. Thanks for taking care of this. I agree with

I want to make sure we're not hung up here, all this stuff is changeable later, let's get to the public API!

Tangentially, thanks for keeping up the rapid pace.