search

sampottinger / co_opencampaigndata

API service for serving Colorado TRACER data for opencampaigndata.org
GNU General Public License v3.0
10 stars 1 forks source link

Configuration files should get their own directory. #26

Closed sampottinger closed 11 years ago

sampottinger commented 11 years ago

With commit d6fa8e67a49ce921e2167fcc4f7663ee96469357, an second JSON configuration file was introduced. If the tracer_db_facade branch is accepted, a new subdirectory for configuration files should be added.

sampottinger commented 11 years ago

More thoughts on this...

tracer_db_config.json acts as a whitelist for operations on the TRACER records database and (likely) will not change based on runtime environment and may (arguably) travel with the repo.

config.json acts more as environment configuration and will (arguably) not travel with the repo in the fullness of time. This would probably be a file that lives on the server and acts as a (slightly more secure / structured) alternative to reading environment variables.

So, I think we may want to keep them separate. Of course, we could have a discussion about the file vs environment vars.

trinary commented 11 years ago

This seems ok to close?

sampottinger commented 11 years ago

+1