search

sampottinger / co_opencampaigndata

API service for serving Colorado TRACER data for opencampaigndata.org
GNU General Public License v3.0
10 stars 1 forks source link

standardize "limit" language #28

Open trinary opened 11 years ago

trinary commented 11 years ago

in query objects, it's resultLimit, in HTTP requests, it's limit, and in HTTP response it's result-set-size. Can we pick one?

trinary commented 11 years ago

or is result-set-size the number of things that were actually returned?

sampottinger commented 11 years ago

Sorry for the confusion. Yea, let's standardize. result-set-size is the number of things that matched the query. So, result-set-size equaling 100 means 100 records matched the user's query but the user could still page through 10 results at a time. I had rational for resultLimit but it felt questionable to me. So, if it was questionable to the both of us, it was probably the wrong decision. I will assign this to me and move to limit.