search

sampottinger / co_opencampaigndata

API service for serving Colorado TRACER data for opencampaigndata.org
GNU General Public License v3.0
10 stars 1 forks source link

data_formatter.js breaks Google Style Guidelines #6

Closed sampottinger closed 11 years ago

sampottinger commented 11 years ago

For the second of two very nit-picky issue reports...

The README currently states that the project conforms to Google's JavaScript Standard guidelines which state that

In general, use functionNamesLikeThis, variableNamesLikeThis, ClassNamesLikeThis, EnumNamesLikeThis, methodNamesLikeThis, CONSTANT_VALUES_LIKE_THIS, foo.namespaceNamesLikeThis.bar, and filenameslikethis.js.

Some variable names introduced in 44f01dce7f6cdab5a2c6972e397b357dedae6ef7 break that convention.

sampottinger commented 11 years ago

Whoops! It looks like I forgot to change json_obj to jsonObj. Needs fix before pull request.

sampottinger commented 11 years ago

Also, double quotes are discouraged by the guidelines.

sampottinger commented 11 years ago

These problems fixed in follow up commits 80dc49df06251468b8905aa953c7a841cdd3e1d1 and 713c8f0ba4d9d526bb4bc5b51b66d8e99d7af47c.