search

sampottinger / processing

Source code for the Processing Core and Development Environment (PDE)
http://processing.org
Other
10 stars 1 forks source link

Making some fields in EditorHeader protected #102

Closed codeanticode closed 5 years ago

codeanticode commented 5 years ago

Right now they are private, which makes it hard to implement derived modes that customize the editor header. By turning into protected fields, they can be accessed from subclasses of EditorHeader, like in this project:

https://github.com/Izza11/shader-mode

sampottinger commented 5 years ago

Hey there! Can totally get behind this. Just want to be careful though that this shouldn't be a PR against mainline? I'm not sure if it's related to this fork's pending changes (ANTLR, CI, Java 11).

codeanticode commented 5 years ago

Thanks! Sure, I will change the base to be the mainline.

codeanticode commented 5 years ago

...not sure if I can do it by editing this PR, so I will just close it and recreate against mainline.