search

sampottinger / processing

Source code for the Processing Core and Development Environment (PDE)
http://processing.org
Other
10 stars 1 forks source link

Revert of sampottinger/processing #3 for java11 branch. #79

Closed sampottinger closed 5 years ago

sampottinger commented 5 years ago

Responding to Ben Fry (@benfry) feedback, reverting the IO refactor PR (#3) across branches. This impacts the root Java 11 branch with the others to follow shortly.

sampottinger commented 5 years ago

Impacts https://github.com/processing/processing/pull/5753

sampottinger commented 5 years ago

For progeny, there is interest in updating the IO code but doing so as part of possibly making things a bit more renderer specific. With that in mind, this reversion leaves as much existing code in place while supporting the Java 11 transition, leaving an opportunity for a future refactor as part of a different potentially larger effort. This will remove some of the testing that I added but I agree that this approach may be more in line with the longer term vision for the project. Also, please note that a switch to 3rd party libraries was not considered in this step but could be evaluated for a future effort.

sampottinger commented 5 years ago

Doing some final testing and will merge back shortly!

sampottinger commented 5 years ago

Quick note: I did leave one unit test from #3 in place related to base64 data decoding due to that API being a little bit in flux from Java 11. It gave me some trouble towards the end and I want to leave a test in to catch regressions just in case.