sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.34k stars 2.92k forks source link

hasAudio for non HTML5 videos #1606

Open surreal8 opened 4 years ago

surreal8 commented 4 years ago

Expected behaviour

When using the hasAudio getter with videos on Vimeo, I expect the value to reflect if the video has an audio track or not.

Actual behaviour

Even when a video does not have an audio track, hasAudio returns true. Does this not work with Vimeo? Seems to be the case notated here: https://github.com/sampotts/plyr/blob/7c442c93571fb5d75f96bff710e310d00e1289e9/src/js/plyr.js#L627

Steps to reproduce

Environment

Console errors (if any)

Link to where the bug is happening

sampotts commented 4 years ago

According to their docs, there's nothing exposed. Even for HTML5 it's flaky. https://github.com/vimeo/player.js