sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.48k stars 2.92k forks source link

No Ad Events fired #1744

Open jaapmarcus opened 4 years ago

jaapmarcus commented 4 years ago

Expected behaviour

Events to be fired that are readable for maybe bug tracking, read out current status and check functionaly of vast tags are working or not

Actual behaviour

No events are fired within the vast plugin

Steps to reproduce

Environment

All

Console errors (if any)

Link to where the bug is happening

Any player with tagUrl set will have no event from the ads plugin.

It would be nice if this can be supported in the future to link up the advertisement performance to Analytics or any other system.

In /src/js/plugins/ads.js there is all ready support for onAdEvent(event) and

onAdError(event) { this.cancel(); this.player.debug.warn('Ads error', event); }

jaapmarcus commented 4 years ago

Ad event to external domains are fired how ever not readable by current browser... It would be nice so it easier to find errors with it.