Open ralyodio opened 4 years ago
I guess it may be time to remove support for custom controls with YouTube and Vimeo (unless Pro/Plus) given this. A few other people have had the same feedback. Even their own advice allows you to customize controls but they must not overlay the player.
Yeah i think the main issue they had was the blue play button over the video. They flat out told me not to customize the player though, I can try to re-submit if we can hide the play button overlay.
maybe hide-overlay flag or something would suffice.
@chovy Are you using their API within an application and then using plyr? The quota would only apply to their API usage. Using Plyr without their API just as a normal video player, they would not know the difference between an iframe stream and plyr.
@sampotts You could probably just add an option for people to disable if they choose and add a warning that Youtube could ask you to discontinue use. But I've never had an issue with Youtube at all. And I hope you do not remove Youtube support as I love using plyr with Youtube, I hate the default Youtube player....
@sparkktv yes I'm using youtube api, and they wanted to see the player setup, they said I need to remove the plyr overlay, you cannot block the youtube video according to their requirements.
@chovy Correct while using their API, but again they have no knowledge that you are not using their player if you are not accessing their API at the same time. So my site, I use Plyr on the website itself but our Amazon app requires their API to be used and on their we use their Youtube Player by default. Because Plyr is using the normal embed that Youtube uses and just using a custom skin on top, Youtube will still think it's their own player. And using a custom player skin is not against their TOS only their API TOS. Video.js being the most popular of all used on many sites. Using their API though, they control the usage and can say what you can't or can do and some usage requires that. And yes they only require that material/screenshot of how you are using Youtube when you need a quota increase. Most of us will never be affected by that. And I might be wrong but I think there is already a way to turn plyr off and show the Youtube player just by using the enabled flag/command and turning it to false.
@sampotts It seems after I did some digging & research that Youtube only asks for supporting materials and how you are using YouTube when you need an API quota increase. This will likely never affect most users using plyr with YouTube. Possibly you should put a disclaimer that Plyr should not be used along with Youtube API. Most people never need to use the API, only if you are developing something that requires it.
@sparkktv can you give me an example of disabling it?
@chovy If you use the iframe method you can use the enabled:false tag to show the Youtube Player instead of the Plyr skin. Using the div non-progressive mode though it can not be done. My only suggestion would be to add a method to turn the Plyr skin on and off for both methods.
That works but now I can't stop the sibling videos when play is clicked.
I can hide the play circle with this:
.plyr--youtube .plyr__control--overlaid {
display: none !important;
}
But I really need the original youtube play button back.
YouTube has informed me that the default video player cannot be customized. I still need plyr to disable simultaneous video playing which works, but can I remove the custom plyr decorations somehow?
They will not increase my quota until I fix this.