sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.38k stars 2.92k forks source link

Expecting end of input, "ADD", "SUB", "MUL", "DIV", got unexpected "RPAREN" #1816

Closed afuno closed 4 years ago

afuno commented 4 years ago

There is a chance that this problem is directly related to your library (primary source: https://github.com/redxtech/vue-plyr/issues/171).

I tried to abandon the VuePlyr library, but the problem persisted.

If I change only the version from ^3.6.1 to ~3.5.10, then everything is deploying successfully.

julkue commented 4 years ago

@sampotts

I have exactly the same problem with using Plyr directly (not a Vue.js plugin):

JisonParserError: Parse error on line 1:
...ar(--plyr-control-padding,calc(var(--plyr-control-spacing,10px)*0.7))) - (var(-...
------------------------------------------------------------------------^
Expecting end of input, "ADD", "SUB", "MUL", "DIV", got unexpected "RPAREN"

Downgrading to 3.5.10 fixes the issue, so it was introduced in the latest release.

alielmajdaoui commented 4 years ago

Same issue here!

Thanks guys for the trick! Downgraded to 3.5.10 and it worked.

sampotts commented 4 years ago

Hmm I guess this is a change as a result of the CSS Custom Properties. Any more info on how I can reproduce this locally? How are you including the CSS?

I might be able to do a CSS build without the custom properties stuff in.

julkue commented 4 years ago

The issue is thrown when usign postcss-calc, respectively I'm using postcss-preset-env which seems to embed it.

francowhyline commented 4 years ago

Hmm I guess this is a change as a result of the CSS Custom Properties. Any more info on how I can reproduce this locally? How are you including the CSS?

I might be able to do a CSS build without the custom properties stuff in.

I am building an angular application with "node --max_old_space_size=6144 ./node_modules/@angular/cli/bin/ng build --configuration=develop"


If I downgrade to 3.5.10 It compiles, but if the video is a vimeo one, it throw an error (using with ngx-plyr) about the video rate (that is solved in last version)

KristianJohansenVakwerk commented 4 years ago

I just tried to downgrade but get a error when I run npm install saying there is No matching version found for vue-plyr@~3.5.10?

Anyone gets the same error?

gorelegacy commented 4 years ago

same issue using node v12.16.2 (npm v6.14.4)

alielmajdaoui commented 4 years ago

@sampotts

... How are you including the CSS?

@import '../../node_modules/plyr/dist/plyr.css';

3.5.10 works fine!

Ka1ki commented 4 years ago

Same issue.

janein commented 4 years ago

Would be nice if this would be fixed soon, as this release contains some nice and important bugfixes! :)

sampotts commented 4 years ago

Will the two PRs above fix this? It's hard for me to test...

mesopa commented 4 years ago

Same problem with Gatsby when running gatsby build.

Generating JavaScript bundles failed

Parse error on line 1:
...r(--plyr-control-padding,calc(var(--plyr-control-spacing,10px) * .7))) - (var(-...
------------------------------------------------------------------------^
Expecting end of input, "ADD", "SUB", "MUL", "DIV", got unexpected "RPAREN"

3.5.10 Works fine.

janein commented 4 years ago

@sampotts I tested it and the build runs through with these changes. :+1:

sampotts commented 4 years ago

@sampotts I tested it and the build runs through with these changes. 👍

Awesome, cheers. I'll get a build out shortly 👍

sampotts commented 4 years ago

Can you folks give v3.6.2 a go? https://github.com/sampotts/plyr/releases/tag/v3.6.2

afuno commented 4 years ago

@sampotts @Bashev I checked. Everything is fine. Thanks.

sampotts commented 4 years ago

Excellent 👍 Thanks goes to @Bashev 👍

davidfilat commented 4 years ago

Works fine on in my project too! Thank you @sampotts !

mesopa commented 4 years ago

Works perfectly with Gatsby, thank you very much.