sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.58k stars 2.93k forks source link

Video quality options (HTML5, YouTube, Vimeo) #218

Closed donnygunawan93 closed 6 years ago

donnygunawan93 commented 8 years ago

please add video quality option for youtube

sampotts commented 8 years ago

Will do. good idea πŸ‘

sampotts commented 8 years ago

From #220 @thelamborghinistory

First of all I just want to say I came here from PH and I instantly fell in love with this player (not only I have a crush on it but it also came up at the perfect time on my screen ;)). So big kudos to you guys.

However, I am curious if it's possible to integrate an option to switch quality of a video like YouTube has (I think half of the functionality for such a feature is already done with the plyr.source() method, so there might just remain a nice dropup menu for the resolution options). What do you think?

From #245 @tamanhquyen

I have created player using your plugins . But i can't change quality on vimeo source . Please help me . Thanks a lot!

gino8080 commented 8 years ago

Definitely need quality option for Vimeo on this great player!

Parasoul commented 8 years ago

Need the video quality option for Youtube !! ^^

masinerija12 commented 8 years ago

Please add a quality change option for html5. Would use this on all my sites. Best looking and fastest html5 player ever! 10/10

shutterarmy commented 7 years ago

Eagerly waiting for the Quality change Option for YouTube like all the others. Amazing player BTW!!

sampotts commented 7 years ago

It's coming along...

image

shutterarmy commented 7 years ago

Yes!!

masinerija12 commented 7 years ago

Looks awesome man. Can't wait.

MelchnerRoman commented 7 years ago

+1 need this

cwbmuller commented 7 years ago

@SamPotts looking great!

hutanatu commented 7 years ago

Looks awesome man. Can't wait.

hitnology commented 7 years ago

@SamPotts Can't wait this feature. I want to change my website and waiting for you since may=.=

robguy21 commented 7 years ago

Is there an ETA for this feature?

Abdalrhmam commented 7 years ago

Great work

diasfelipe commented 7 years ago

Looks good, can't wait.

singleseeker commented 7 years ago

How`s it going?

aolko commented 7 years ago

Is it done and can be pushed to the master branch?

sampotts commented 7 years ago

No, but my baby son is and is growing well. Sorry, he takes priority right now.

tonmoy-ajize commented 7 years ago

Waiting for this badly.

sampotts commented 7 years ago

I've been managing to squeeze in some more time here and there in between changing nappies and getting the little fella to sleep. Sorry it's just been a bit more complicated than previous changes given all the new UI components and having a kid in the middle of it wasn't well planned.

This is going to be launched along with:

I'm getting there just hang in there πŸ‘

image

POPSuL commented 7 years ago

Great! :+1:

tonmoy-ajize commented 7 years ago

It looks great ... Not it became more teasing than before πŸ‘

CalebKester commented 7 years ago

@SamPotts let's us know if you need help testing this. I'd be happy to help out in what ways I can. I've been using your library in a vuejs project and really enjoying it.

sampotts commented 7 years ago

Cool - I'm hoping to get a working version up and running in develop soon. Just trying to find more time.

mkdub commented 7 years ago

Hey Sam,

How's life juggling the baby and code, I can't even imagine! Hope alls been well.

I am looking forward to your new release of features that's coming our way soon, I had a quick question for you. Will we be able to set the default for the vimeo links to load in HD? I am currently building a website that the user is not able to change controls to the player but I'd still like to load the videos in HD.

Take care!

sampotts commented 7 years ago

Hey,

I'm getting there slowly. I keep chipping away at it when I get a few minutes.

Vimeo's API is fairly limited and doesn't allow control over the quality like YouTube does unfortunately. It seems to be "auto" the majority of the time for me - mostly loading in HD.

Nice VWs! I have an R36 wagon and Audi S3 8L myself πŸ‘

xdajay commented 7 years ago

Hey @SamPotts .

First of all, Thank you for making such a great HTML5 player πŸ‘
Video Quality option for Direct MP4 Video will be there? If yes, Please let me know, Will integrate on https://burffee.com

ewwink commented 7 years ago

any update?

sampotts commented 7 years ago

Nope, still working on it. You'll see here when there's updates. Sounds like we'll have a load of testers πŸ‘ I'm trying to find time where I can to get it done but as I'm sure you're aware (judging by your avatar) - there's a shortage of time when you have a kid.

ewwink commented 7 years ago

I understand, OK we will wait and thanks for your work and time.

An0nymous0 commented 7 years ago

Quality selection function What time to launch?

sampotts commented 7 years ago

See above. Plyr isn't a commercial, paid product. I do it in my spare time for free.

mkdub commented 7 years ago

I think if there's enough people here that are requesting certain updates, we should all come together and donate to help Sam. We should make sure it's worth his time to put the effort to make something we all use even greater.

tonmoy-ajize commented 7 years ago

Totaly agreed to @mkdub .. I am ready to send some help to Sam.

Looking forward to Sam if he can really give us some time ...

jwjcmw commented 7 years ago

Just a reminder that there is a donate link in the readme...use it (I'm about to).

sampotts commented 7 years ago

Thanks for the donations guys. Really nice of you. I'll set aside as much time I can this weekend to make progress on the remaining items on my list. πŸ‘

mkdub commented 7 years ago

To save people time, as we all now understand time=money.

Here is the direct link to donate. Anything you can put in will go a long way, it's not just for this feature but everything else that will keep this great plugin at the top.

xblabs commented 7 years ago

@mkdub Awesome, just sent some support Sam's way. Very much looking forward to seeing the HTML5 HD switch come to live. I can already see it in the dev branch for Youtube. Awesome.

aolko commented 7 years ago

...and then most people forgot about this

sampotts commented 7 years ago

...and then most people forgot about this

I'm not sure what you mean? No one's forgotten and I've been putting in as much time on it as I can. So far it only works for YouTube and their API is pretty flaky in this area. The video will play back with "auto" as the default (they determine it based on connection) and from there you can only increase quality it seems. i.e. attempting to go from 720P to 1080P is fine but downgrading doesn't seem to work. The way the API works is you "suggest" a quality and it may or may not change the actual quality - you listen for an event to indicate the quality has changed.

Vimeo does not expose the ability to toggle from SD to HD and vice versa. They don't allow a lot in their API but what they do allow works well.

HTML5 quality control will have to come later, I'm not sure how to tackle that one quite yet.

The main delay is that I'm trying to do too much at once really, the main features in v3 include:

...accompanied with a fairly hefty re-write in preparation for ES6 and making the lib more modular.

xblabs commented 7 years ago

@sampotts awesome Sam. Thanks for the feedback and thanks for putting the effort in besides busy family life! In terms of the HD toggle for HTML5, would it be possible to have a way to extend the controls with a view / icon and registering a custom callback so those who need it might be able to implement it themselves? Same for a HTML5 download button.

EnziinSystem commented 7 years ago

@sampotts , thanks so much.

POPSuL commented 7 years ago

@sampotts, the quality selector will be implemented only for YouTube/Vimeo, or for type: 'video' will also be implemented?

ajoykarmakar459 commented 7 years ago

When the quality features add in your product?

SadeqRasheed commented 7 years ago

Thank you for this amazing player, can i get an early access somehow ? i really need the quality options even if they are not stable πŸ’ƒ

friday commented 7 years ago

@SadeqRasheed: You can access v3 in the develop-branch. I'm already doing that (only for subtitles), but it's not recommended. Some features are partially implemented and will break unless you disable them.

sampotts commented 7 years ago

Yeah as @friday said really. It's still buggy at the moment. I am chipping away at it as much as I can and am close but still doing a lot of testing and fixing bugs. This version should be a lot more stable as a result but again, I can't guarantee when it will be done other than as soon as I can get it out the door.

As for @POPSuL for now it'll be YouTube only. Vimeo doesn't expose their HD toggle. HTML5 will follow soon after (and should be relatively straight forward) but I want to get it out rather than keep delaying.

jeffreymeng commented 6 years ago

I've just found your library. It's Awesome!

Just one question: Is there going to be some sort of an api to add your own options to the popup? Like a function to add a component, and links within that component, and each link runs a callback function(or something like that)?

mayeaux commented 6 years ago

Could really use this πŸ™ƒ +1