sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.38k stars 2.92k forks source link

Captions size issue. #2258

Open geetesh07 opened 3 years ago

geetesh07 commented 3 years ago

Hello,

  1. I have edited the captions size part in style.min.css file, but when I start the video the captions are small. Can anyone tell me the optimal size for caption. Also when I edited the captions, different parts of the player will enlarged. I believe its a mistake on my part. So can you tell me were to edit the code or edit the code and set optimum caption size. style.min.zip
  2. When i am trying to change the background/preview/banner image the changes are not showing up. Please guide me through it.

Thanks for the work Sam :) Really really appreciate it.

muhy06 commented 3 years ago

I had the same issue recently.

I found the solution playing with fonts sizes.

Here is my css file, this works well both with desktop and mobile. If this does not help let me know.

plyr.zip

geetesh07 commented 3 years ago

Sure, I will try. You are a life saver mate :)

geetesh07 commented 3 years ago

I had the same issue recently.

I found the solution playing with fonts sizes.

Here is my css file, this works well both with desktop and mobile. If this does not help let me know.

plyr.zip

I tried it still having the same issues, the captions are really small

muhy06 commented 3 years ago

check on this link if this caption size is good enough :

https://www.dramaice.com/watch/my-roommate-is-a-gumiho-2021-episode-12

they are using the same css i gave you.

geetesh07 commented 3 years ago

Maybe its not only about the css but also about the plyr files as whole. Mind sharing all the files. Ofc if you are comfortable.

On Sat, 3 Jul 2021 at 18:17, muhy06 @.***> wrote:

check on this link if this caption size is good enough :

https://www.dramaice.com/watch/my-roommate-is-a-gumiho-2021-episode-12

they are using the same css i gave you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sampotts/plyr/issues/2258#issuecomment-873402456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZAZX7Q7LXVNVBXVDEZM5LTV4BGJANCNFSM47TZSR2Q .

geetesh07 commented 3 years ago

check on this link if this caption size is good enough :

https://www.dramaice.com/watch/my-roommate-is-a-gumiho-2021-episode-12

they are using the same css i gave you.

You have got a cool website btw. Its really nice. Also i checked your css it was almost same to the one i had so ig other files have a role in it

muhy06 commented 3 years ago

Thank you :)

I have not made any change to the js or any other file. but happy to share. plyr.zip

geetesh07 commented 3 years ago

na na bro i didnt ask for the .js file but this file--- plyr.php

Thank you :)

I have not made any change to the js or any other file. but happy to share. plyr.zip

geetesh07 commented 3 years ago

Thank you :)

I have not made any change to the js or any other file. but happy to share. plyr.zip

didnt work still same..😢 https://videos.anime-kisa.xyz/video/DeathNote-30

jloewe commented 3 years ago

I found a workaround for the issue. It seems like vimeo tries to enable the captions for the locale they detect for your browser. To mitigate this I called this.player.embed.disableTextTrack(); in the player on ready hook, which worked most reliably with a timeout of a few seconds.

plyr.on("ready", () => {
  setTimeout(() => { plyr.embed.disableTextTrack(); }, 2000);
});
geetesh07 commented 3 years ago

Awesome, thanks!

On Thu, 15 Jul 2021 at 17:13, Jan Loewe @.***> wrote:

I found a workaround for the issue. It seems like vimeo tries to enable the captions for the locale they detect for your browser. To mitigate this I called this.player.embed.disableTextTrack(); in the player on ready hook, which worked most reliably with a timeout of a few seconds.

plyr.on("ready", () => { setTimeout(() => { plyr.embed.disableTextTrack(); }, 2000);});

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sampotts/plyr/issues/2258#issuecomment-880626624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZAZX6LNBKPHAPTCFLXUVLTX3CVBANCNFSM47TZSR2Q .