sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.59k stars 2.93k forks source link

iOS controls appear over plyr control when exiting native fullscreen by swiping down to exit #2278

Open mrleblanc101 opened 3 years ago

mrleblanc101 commented 3 years ago

Expected behaviour

iOS controls should never be shown and should not block plyr custom controls.

Actual behaviour

iOS controls appear over plyr control when exiting native fullscreen by swiping down the player. This will not happen if the native player is dismissed by using the close button in the upper-left.

Steps to reproduce

Environment

Example swiping down to exit 2021-07-20 10 45 27

Example using the close button 2021-07-20 10 43 49

mannyveloso commented 3 years ago

Same issue here, iOS controls take over in fullscreen on iOS. Note this doesn't happen on iPadOS.

mrleblanc101 commented 3 years ago

@mannyveloso I don't think your issue is related. My issue is after exiting Fullscreen by swiping down. Not while in fullscreen.

mannyveloso commented 3 years ago

So you see the plyr controls when playing on iOS ie: if you touch the video while playing you see the plyr controls, not the iOS controls? That's interesting, we see the exact opposite: when we play a video the iOS controls take over and when we swipe down we see the plyr controls.

What iOS are you on? Ours is on 14.7.1

mrleblanc101 commented 3 years ago

@mannyveloso Did you look at the gif or...? When in fullscreen, iOS controls are shown because I have fullscreen: { iosNative: true }.

mannyveloso commented 3 years ago

I did; the 2nd video shows iOS video controls before the close button is clicked and what I presume are your custom controls when the video stops.

mrleblanc101 commented 3 years ago

Can you create you own issue instead of polluting mine ? Clearly your problem is totally unrelated. The fact that iOS control display in fullscreen is totally normal as I said because I have the option { fullscreen: iosNative: true }. Maybe you should go read the documentation: image

mannyveloso commented 3 years ago

Yes I will to be stopping polluting your issue. Thanks for your help and understanding, I'm sure that I'll try and do the same sometime in the future.