Allow passing existing embed <iframe> to constructor

vibhi19 commented 7 years ago

Hi Thanks for awesome Player

Can You provide code for player automatically works on video embedded through YouTube Iframe on post

sampotts commented 7 years ago

I think what @vibhi19 is referring to is setting up Plyr on an already loaded embed <iframe>. It's something I've considered doing but won't be part of v3. I like it though as it's true progressive enhancement as the HTML5 player is.

vibhi19 commented 7 years ago

Yes im referring to is setting up Plyr on an already loaded embed </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>HEY i have a lot of video in WordPress embed through iframe can You Provide code which Will convert those iframe to Support player i really want to use this player</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Did you read my comment? It's not supported yet. It's already in the backlog and coming. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Hi Wordpress Plugin work But i create problem In mobile devices so Im Thinking you can provide some code like This i have one but its not working here</p> <p>` // Iframe and find Autoplay $YTiframe = '/<iframe.<em>?(width="[0-9]</em>")?.?(height="[0-9]<em>")?.</em>?src=".<em>?youtube.com\/embed\/(\w</em>-?\w<em>).(autoplay=1)?.</em>?<\/iframe>/i';</p> <pre><code>$YTreplace = '<div data-type="youtube" data-video-id="$3">'; $content = preg_replace( $YTiframe, $YTreplace, $content `);``</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>can You take a look and Tell me why its not working </p> <pre><code> // Iframe and find Autoplay $YTiframe = '/<iframe.*?(width="[0-9]*")?\.?(height="[0-9]*")?\.*?src=".*?youtube\.com\/embed\/(\w*\-?\w*).(autoplay=1)?.*?<\/iframe>/i'; $YTreplace = '<div data-type="youtube" data-video-id="$3">'; $content = preg_replace( $YTiframe, $YTreplace, $content );</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>I'll update once it's supported 👍 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>What You mean</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>I Tried but its not working for me </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Are you reading my comments or just brushing over them. </p> <h3>It's not supported yet - as in it doesn't work yet</h3> <h3>I will be adding support for it soon</h3> <h3>I will update this issue when it works (no firm date)</h3> <p>Hope that clears it up for you </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>bro I read It i totally understand that you update this in next update but right now but if You can Help me Replace youtube iframe with Plyr plater That will be Helpful Any code which can do that please Im using wordpress </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>You could try the WordPress plugin as listed in the docs </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>I did but its Play button doesnt work in Mobile device You have click on full screen then click on play </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>That's a limitation of iOS. It's addressed in v3 but I'm not finished with it yet. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>No im talking about android Phone i dont use ios</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>and if i use Script then the play button work pefectly</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Well thanks for Your Time What i can do Waiting for Update </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>I'll keep this issue open as a reference until I've added support. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Ok </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vibhi19"><img src="https://avatars.githubusercontent.com/u/31093426?v=4" />vibhi19</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Issue Solved Updated The css and Js Files in Plugin and Boom hehehe </p> <p><a href="https://drive.google.com/open?id=16-X-79UIjzusZ1lM5vBH5Tgp7dLWO7wy">https://drive.google.com/open?id=16-X-79UIjzusZ1lM5vBH5Tgp7dLWO7wy</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sampotts"><img src="https://avatars.githubusercontent.com/u/719092?v=4" />sampotts</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Closing this one as I think it's fixed but feel free to re-open if not solved in v3 👍 </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

sampotts / plyr

Allow passing existing embed <iframe> to constructor #722