sampotts / plyr

A simple HTML5, YouTube and Vimeo player
https://plyr.io
MIT License
26.61k stars 2.93k forks source link

polyfill.io alias for plyr #953

Open friday opened 6 years ago

friday commented 6 years ago

I think we should add plyr as an alias on polyfill.io, making the link to add now and in the future https://cdn.polyfill.io/v2/polyfill.min.js?features=plyr. They do support this use case for at least one other project that I'm aware about. It would make it easier to get started with Plyr 3 and polyfills, and this would mean that we take responsibility for it, rather than leaving this to Plyr users. For example, URL was added recently to the list of polyfills the demo uses, but users who upgrade their code will not get the URL polyfill, only the dependency on it.

It would complicate the release procedures a bit since they don't release very often. So we have to generally avoid adding new polyfill dependencies, and plan these weeks ahead in addition to browser test IE11 a lot more carefully.

Suggested additions besides what's in the demo: Element.prototype.classList (IE only partially support it)

friday commented 6 years ago

To fix before this task: #883 #937