search

sampotts / shr

Simple, clean, and customizable social sharing buttons.
MIT License
152 stars 22 forks source link

Local storage test is flawed. #2

Closed danfoley closed 7 years ago

danfoley commented 7 years ago

this block of code here should be removed from the local storage test:

if ('localStorage' in window && window.localStorage !== null) {
        return false;
}

that is going to return false if something else already is using local storage, even thought it still is available for use. Remove that block and all will be fine.

danfoley commented 7 years ago

see here: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/storage/localstorage.js

sampotts commented 7 years ago

Merged your PR, cheers 👍