search

sampotts / shr

Simple, clean, and customizable social sharing buttons.
MIT License
152 stars 22 forks source link

Usage as npm package #21

Closed victor-gabou closed 5 years ago

victor-gabou commented 5 years ago

Hi,

Thanks for this lib and the others, your work is very appreciated! I was wonder, did you plan to publish shr on npm?

Bests 👍

sampotts commented 5 years ago

Hey @victor-gabou,

Yep that's the plan. I'm in the middle of rewriting it into ES6 and some friends are adding some extra functionality also. Should be done in the next 1-2 weeks 👍

Cheers

victor-gabou commented 5 years ago

Nice 👍

Seeing that you're talking about adding features, did you plan to add the linkedin share?

Thanks

sampotts commented 5 years ago

I'm sure it could be done. I'll add it to the list but we'll probably get this first iteration done and out first.

victor-gabou commented 5 years ago

Ok cool !

If I have time to work on the linkedin share in the next few days, do you prefer a PR on the master branch or on the develop branch?

sampotts commented 5 years ago

Develop would be best but maybe give it a week as I'm working on the re-write still.

victor-gabou commented 5 years ago

Yes of course, that's why I asked 😄 Don't hesitate to ping when it's ready !

sampotts commented 5 years ago

Will do.

sampotts commented 5 years ago

It's published under shr-buttons but v2.x is still beta really. Please let me know if you run into any issues.

victor-gabou commented 5 years ago

The project I was working on has ended, I'll let you know if I run into any issues in my next projet!