sampsaoinonen / TiRa-RouteOptimizer

RouteOptimizer is a navigational tool that uses and compares A* and Fringe Search pathfinding algorithms to find the most efficient route in Helsinki capital region street network.
0 stars 0 forks source link

peer review #2

Open sanikk opened 3 hours ago

sanikk commented 3 hours ago

loaded 19-10-2024 21:01 (not exact)

I moved some of your work to octile maps and ran it on my testbed.

notes from fringe that was moved to octile:

The removal of 'current' might be a bit slow to match A*. I used about 120 step paths for testing, and the fringe was about 1200 nodes long at worst. That path had 3835 expansions, so that many removals, too. These will add up.

Some test runs: visited=167238, expanded=11473 visited=379, expanded=132 visited=27751, expanded=5252 visited=8854, expanded=3888 visited=1213, expanded=390 visited=45817, expanded=2868 visited=337, expanded=142 visited=232, expanded=116 visited=22296, expanded=1626 visited=25823, expanded=3426

The visit/expansion rate is pretty good. Nice work there.

You can do 'now' and 'later' with one deque, but that's just personal preference.

And A* was much faster.