search

sampsapursiainen / zeffiro_interface

Interface for using finite elements in inverse problems with complex domains
GNU General Public License v3.0
24 stars 15 forks source link

Turn external/ libraries into Git submodules #156

Closed SeSodesa closed 1 year ago

SeSodesa commented 1 year ago

This would make their installation much more effortless with a simple

git clone --recurse-submodules https://github.com/sampsapursiainen/zeffiro_interface.git

or

git clone --recursive https://github.com/sampsapursiainen/zeffiro_interface.git

The addition of the external libraries as Git submodules could be done with (for example)

git submodule add https://github.com/cvxr/CVX.git external/CVX

in the case of the CVX module. The file .gitignore allowlist also needs to be updated to allow the .gitmodules file for this to work.

SeSodesa commented 1 year ago

Closed by #157.