Replace the script fs2zef.sh with the Matlab function mri2mesh.fs2zef

sampsapursiainen / zeffiro_interface

Interface for using finite elements in inverse problems with complex domains

GNU General Public License v3.0

24 stars 15 forks source link

Replace the script fs2zef.sh with the Matlab function mri2mesh.fs2zef #193

Closed SeSodesa closed 1 year ago

SeSodesa commented 1 year ago

Add a new function +mri2mesh/fs2zef.m that handles the role of the old fs2zef.sh. Requires at least Matlab R2019a.
Allow .dat files in the subdirectories of this project via .gitignore.
Include updated import_segmentation.zef and an example electrodes.dat file under +mri2mesh/.

Closes #191, #192 and #197 . Do not merge until ready.

SeSodesa commented 1 year ago

Awesome job, everything seems to work smoothly ✨

Let's also not forget to (in another PR?):
* [ ]  Remove an outdated fs2zef.sh script

* [ ]  Move the documentation to the wiki page and refer to it from the readme.md or from the script file itself

The README from +mri2mesh should already be on the Wiki pages (link). We might consider that item resolved already, unless there is still something that could be improved on the page.

SeSodesa commented 1 year ago

I think I will squash the commits and merge this, then, since the README has already been copied over to the wiki pages. We can do the removal of the old redundant files in a separate context, dedicated to it and only it. This will make it easier to find a point in the project history where the removal was done, in case something will be missed.