search

sampsapursiainen / zeffiro_interface

Interface for using finite elements in inverse problems with complex domains
GNU General Public License v3.0
23 stars 15 forks source link

Allow importing electrodes to an existing project #222

Closed SeSodesa closed 1 year ago

SeSodesa commented 1 year ago

Description

Currently, the only way of importing electrodes into a project is during the import of a segmentation, by placing an electrodes.dat file into the same folder with the segmentation to be imported, and then going to Menu tool > Import > Import data to a new project, and choosing the import_segmentation.zef script in the same folder. It would be beneficial, if electrodes could be imported into an existing project after the segmentation has already been imported, so that different electrode configurations could be used in simulations with the same head model more effortlessly.

Expected behavior

One would expect there to be a working button Menu tool > Import > Import electrodes, that would allow one to select a file of electrode positions and labels, which would then get imported to the project.

Context

Name Value
Version f958de80 Merge pull request #193 from sampsapursiainen/192-fs2zefsh-improvements
OS Any and all
Shell Any and all
SeSodesa commented 1 year ago

It looks like the related pull request was closed. I think we can mark this as resolved for now, although I'm not sure if all related concerns were addressed quite yet. These were mainly related to whether the added electrode import routine calls all of the necessary update functions, so all of the related information is updated in the GUI/zef.