sampsapursiainen / zeffiro_interface

Interface for using finite elements in inverse problems with complex domains
GNU General Public License v3.0
23 stars 15 forks source link

zef_waitbar errors when an integer is passed in as the first argument #229

Closed SeSodesa closed 1 year ago

SeSodesa commented 1 year ago

Description

The function zef_waitbar throws an error, if an integer is passed in as the first argument, as the deprecated datestr function cannot handle integers.

Steps to reproduce

  1. Pass in an integer as the first argument, while updating the waitbar with a 3-argument call zef_waitbar(progress_ratio,waitbar handle,waitbar text), where progress_ratio is an integer type.
  2. After a few iterations, the waitbar crashes.

Expected behavior

The waitbar should be able to handle integers as input. The first argument shold be converted to a double by the zef_waitbar function.

Context

Name Value
Version 7ac852b94 Merge pull request #218 from sampsapursiainen/217-code-style-and-indentations
OS Any and all
Shell Any and all
SeSodesa commented 1 year ago

Closed after merge of related pull request.