search

sampsapursiainen / zeffiro_interface

Interface for using finite elements in inverse problems with complex domains
GNU General Public License v3.0
23 stars 15 forks source link

handle errors in zef_start_config #235

Closed SeSodesa closed 1 year ago

SeSodesa commented 1 year ago

Description

Currently, if a user has not properly installed Zeffiro, either by instantiating the Git submodules in external/ with 

git clone --recurse-submodules https://github.com/sampsapursiainen/zeffiro_interface.git

or with an already cloned project with

git submodule update --init --recursive

or by using zeffiro_downloader in the project root, the calls to evalc in m/zef_start_config.m end up throwing errors. This is unnecessarily restrictive, as only a small subset of Zeffiro Interface uses the included optimization libraries.

Steps to reproduce

  1. Download Zeffiro Interface without also instantiating the submodules.
  2. Try to start up the program.
  3. Encounter an error related to missing symbol, usually cvx_startup or ft_defaults.

Expected behavior

One would expect the program to issue a warning dialogue about missing dependencies, and then continue with the startup. Another option is that an error dialogue is opened with instructions regarding the installation of the submodules, if it is deemed a critical enough thing

Screenshots

image

Context

Name Value
Version 3ec93b22 Merge pull request #234 from sampsapursiainen/more-options-to-utilities-colorbar-from-fig-fn
OS Any and all
Shell Any and all
SeSodesa commented 1 year ago

Closed by #236.