sampson-matt / FlyCasual

Fan-made "Star Wars: X-Wing Miniatures Game" simulator
MIT License
23 stars 1 forks source link

Xws import issues #16

Open grandpajive opened 1 year ago

grandpajive commented 1 year ago

@sampson-matt may I create an issue with missing/incorrect xws data (pilots/upgrades etc)?

I usually send import issues to Sandrem's project, but if you are willing to update the xws import data, I can create issues in your project.

sampson-matt commented 1 year ago

You can definitely report them here. I'm guessing at least some of the issues are caused by pilots or upgrades not being coded yet. There may also be issues with using imports from a 2.5 list builder, but I'll try to fix anything I can.

grandpajive commented 1 year ago

You can definitely report them here. I'm guessing at least some of the issues are caused by pilots or upgrades not being coded yet. There may also be issues with using imports from a 2.5 list builder, but I'll try to fix anything I can.

Cool, I'll use this issue, and add new items as new pilots/ships are added.

grandpajive commented 1 year ago

@sampson-matt this is what I found so far.

Titles: ST-70 Assault Ship - Razor Crest Title (and functionality) "pilots":[{"id":"q90","name":"q90","points":6,"ship":"st70assaultship","upgrades":{"title":["razorcrest"]}}],"points":6

Pilots:

Scum Cad Bane (Rogue Class Star Fighter) "pilots":[{"id":"cadbane","name":"cadbane","points":5,"ship":"rogueclassstarfighter"}

BoY/SoC Pilots:

All BoY Rebels:

"pilots": [{"id":"dextiree-battleofyavin","name":"dextiree-battleofyavin","points":4,"ship":"btla4ywing"} ,{"id":"holokand-battleofyavin","name":"holokand-battleofyavin","points":4,"ship":"btla4ywing"} ,{"id":"dutchvander-battleofyavin","name":"dutchvander-battleofyavin","points":4,"ship":"btla4ywing"} ,{"id":"popskrail-battleofyavin","name":"popskrail-battleofyavin","points":4,"ship":"btla4ywing"} ,{"id":"garvendreis-battleofyavin","name":"garvendreis-battleofyavin","points":4,"ship":"t65xwing"} ,{"id":"jekporkins-battleofyavin","name":"jekporkins-battleofyavin","points":4,"ship":"t65xwing"} ,{"id":"biggsdarklighter-battleofyavin","name":"biggsdarklighter-battleofyavin","points":5,"ship":"t65xwing"} ,{"id":"wedgeantilles-battleofyavin","name":"wedgeantilles-battleofyavin","points":5,"ship":"t65xwing"} ,{"id":"lukeskywalker-battleofyavin","name":"lukeskywalker-battleofyavin","points":6,"ship":"t65xwing"} ,{"id":"hansolo-battleofyavin","name":"hansolo-battleofyavin","points":7,"ship":"modifiedyt1300lightfreighter"}]

All BoY Empire: "pilots": [{"id":"darthvader-battleofyavin","name":"darthvader-battleofyavin","points":6,"ship":"tieadvancedx1"} ,{"id":"sigma4-battleofyavin","name":"sigma4-battleofyavin","points":4,"ship":"tieininterceptor"} ,{"id":"sigma5-battleofyavin","name":"sigma5-battleofyavin","points":4,"ship":"tieininterceptor"} ,{"id":"sigma6-battleofyavin","name":"sigma6-battleofyavin","points":4,"ship":"tieininterceptor"} ,{"id":"sigma7-battleofyavin","name":"sigma7-battleofyavin","points":4,"ship":"tieininterceptor"} ,{"id":"idenversio-battleofyavin","name":"idenversio-battleofyavin","points":6,"ship":"tieininterceptor"} ,{"id":"maulermithel-battleofyavin","name":"maulermithel-battleofyavin","points":3,"ship":"tielnfighter"} ,{"id":"wampa-battleofyavin","name":"wampa-battleofyavin","points":3,"ship":"tielnfighter"} ,{"id":"backstabber-battleofyavin","name":"backstabber-battleofyavin","points":4,"ship":"tielnfighter"} ,{"id":"darkcurse-battleofyavin","name":"darkcurse-battleofyavin","points":4,"ship":"tielnfighter"}]

All SoC Republic:

"pilots": [{"id":"jag-siegeofcoruscant","name":"jag-siegeofcoruscant","points":4,"ship":"arc170starfighter"} ,{"id":"wolffe-siegeofcoruscant","name":"wolffe-siegeofcoruscant","points":4,"ship":"arc170starfighter"} ,{"id":"oddball-siegeofcoruscant","name":"oddball-siegeofcoruscant","points":5,"ship":"arc170starfighter"} ,{"id":"obiwankenobi-siegeofcoruscant","name":"obiwankenobi-siegeofcoruscant","points":4,"ship":"eta2actis"} ,{"id":"shaakti-siegeofcoruscant","name":"shaakti-siegeofcoruscant","points":4,"ship":"eta2actis"} ,{"id":"anakinskywalker-siegeofcoruscant","name":"anakinskywalker-siegeofcoruscant","points":5,"ship":"eta2actis"} ,{"id":"contrail-siegeofcoruscant","name":"contrail-siegeofcoruscant","points":3,"ship":"nimbusclassvwing"} ,{"id":"klick-siegeofcoruscant","name":"klick-siegeofcoruscant","points":3,"ship":"nimbusclassvwing"} ,{"id":"kickback-siegeofcoruscant","name":"kickback-siegeofcoruscant","points":3,"ship":"v19torrentstarfighter"} ,{"id":"axe-siegeofcoruscant","name":"axe-siegeofcoruscant","points":4,"ship":"v19torrentstarfighter"}]

All SoC Separatists: "pilots": [{"id":"dis347-siegeofcoruscant","name":"dis347-siegeofcoruscant","points":4,"ship":"droidtrifighter"} ,{"id":"phlacarphoccprototype-siegeofcoruscant","name":"phlacarphoccprototype-siegeofcoruscant","points":4,"ship":"droidtrifighter"} ,{"id":"dist81-siegeofcoruscant","name":"dist81-siegeofcoruscant","points":5,"ship":"droidtrifighter"} ,{"id":"baktoidprototype-siegeofcoruscant","name":"baktoidprototype-siegeofcoruscant","points":3,"ship":"hyenaclassdroidbomber"} ,{"id":"dbs32c-siegeofcoruscant","name":"dbs32c-siegeofcoruscant","points":3,"ship":"hyenaclassdroidbomber"} ,{"id":"dbs404-siegeofcoruscant","name":"dbs404-siegeofcoruscant","points":3,"ship":"hyenaclassdroidbomber"} ,{"id":"countdooku-siegeofcoruscant","name":"countdooku-siegeofcoruscant","points":6,"ship":"sithinfiltrator"} ,{"id":"dfs081-siegeofcoruscant","name":"dfs081-siegeofcoruscant","points":2,"ship":"vultureclassdroidfighter"} ,{"id":"haorchallprototype-siegeofcoruscant","name":"haorchallprototype-siegeofcoruscant","points":2,"ship":"vultureclassdroidfighter"} ,{"id":"dfs311-siegeofcoruscant","name":"dfs311-siegeofcoruscant","points":3,"ship":"vultureclassdroidfighter"}]

sampson-matt commented 1 year ago

Most of these should be fixed in the latest release. The Razor Crest Title doesn't exist yet, so that will definitely still error. There are also a few SoC and BoY pilots that are complete duplicates of existing pilots, so I didn't bother to add them to FlyCasual... but that breaks the import function. I'm still thinking on what the cleanest most maintainable solution is for this.

If you spot any more, please let me know!