search

sampsyo / hooknook

a little place for your deployments
47 stars 4 forks source link

User list in config file not working #10

Closed pavpanchekha closed 8 years ago

pavpanchekha commented 9 years ago

I can put a Python list in the configuration file, but it still doesn't work. I'm setting users on the command line, but it'd be better to avoid this.

sampsyo commented 9 years ago

Hmm; it's working with our setup, where the config looks like this: 

USERS = ['sampsyo', 'uwsampa', 'bholt', 'jamesbornholt']

That's not doing it for you (neither for the web login nor for whitelisting the allowed repositories)?

pavpanchekha commented 8 years ago

Yep, I added

USERS = ['sampsyo', 'uwsampa', 'bholt', 'jamesbornholt']

to my config, but it won't let me in to the web login. I've got a script that starts it with the right flags, so it's not urgent, but it sure would be good to know what's borked.

sampsyo commented 8 years ago

Oh! I see the problem. The command-line flags are overriding the configuration in run, so the config is getting (mostly) ignored. Oops. I didn't notice because I'm running Hooknook with a separate HTTP server (Gunicorn) instead of the built-in Flask one, so I'm bypassing the run function altogether.

I'll fix this up.

pavpanchekha commented 8 years ago

Thanks!

sampsyo commented 8 years ago

That should do it! :sparkles: