search

sampsyo / wideq

reverse-engineered client for the LG SmartThinQ API
https://pypi.org/project/wideq/
MIT License
332 stars 158 forks source link

Mypy CI #72

Closed gladhorn closed 4 years ago

gladhorn commented 4 years ago

After adding a few type annotations, let's keep things clean by checking that mypy is still happy when changes are made. This finds some coding errors.

sampsyo commented 4 years ago

Good idea! I'm also trying out GitHub actions, because I've never used them heavily before and the potential for inline annotations seems nice. So I'll try adding MyPy to that as well.

sampsyo commented 4 years ago

Also, thanks for all your help recently!! I'm sending you a collaborator invitation so you should be able to merge your own PRs if you like or commit directly. Always happy to do a code review in any case, of course.