samrap / outrun-theme-vscode

A theme for VS Code inspired by the colors, style, and culture of the synthwave music scene.

https://outruntheme.com

96 stars 12 forks source link

:sparkles: (JS syntax enhancment) Some JS syntax enhancment #12

Closed hhochart closed 1 year ago

hhochart commented 5 years ago

Function declaration & call is no longer white and is now orange
Class instantiation is now blue according to PHP screenshot.

4 Related (still WIP)

sr-scott commented 5 years ago

Stumbled upon this theme today and really like it but also felt the JS syntax highlighting could use a bit of work, so was pleased to see someone taking up the challenge! 😄 Really like the look of the screenshot here! My only suggestion would be that object literal keys should probably use a different colour. Just my two cents :) Really appreciate the work so far! Look forward to seeing this merged!

hhochart commented 5 years ago

Thanks ! I tried to stay as close as possible to the original PHP syntax for the object literal keys, so that's why i left them white for now.

sr-scott commented 5 years ago

@hhochart29 You looking to fork the theme then?

hhochart commented 5 years ago

I did a fork and tried today to put my version on the marketplace but didn't seem to work. will give another try !

sr-scott commented 5 years ago

@hhochart29 I'll look out for it as I'd definitely like to see a version of this theme go forward but with better JS syntax support.

hhochart commented 5 years ago

There you go @sr-scott https://marketplace.visualstudio.com/items?itemName=hhochart29.outrun You can submit PR or issue if you have something you'd like to see :)

sr-scott commented 5 years ago

Whoop! I'll move further discussion to your repo then :)

chaosharmonic commented 3 years ago

@hhochart29 throwing this here as your repo doesn't appear to have issues enabled and upstream looks unmaintained -- any way you'd consider also publishing this to the Open VSX registry?

It would make this accessible to downstream projects like Theia and VSCodium, which can't access the VS Code Marketplace for licensing reasons. (In particular, various Arch Linux distros ship with Code-OSS builds by default.)

Here's a link to some relevant documentation from the OVSX wiki.

hhochart commented 3 years ago

Hi @chaosharmonic , i've opened issues on my own fork. I'll take a look about publishing to OVSX. I'm quite busy atm but i'll look at this whenever i have few minutes :) thanks