samreid / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

general shapes are not filled correctly under SWT #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Create a PSWTPath with a polyline
2.Set different stroke and background colors
3.Observe the result

Obviously, the fill(final Shape s) method in SWTGraphics2D calls the wrong 
sub-method. The fix (bd2) is:

...
            Path p = (Path) SHAPE_CACHE.get(s);
            if (p == null) {
                p = pathIterator2Path(s.getPathIterator(null));
                SHAPE_CACHE.put(s, p);
            }
//            drawPath(p);
            fillPath(p); // bd2
        }
    }

Original issue reported on code.google.com by berthold...@gmail.com on 21 Aug 2010 at 6:26

GoogleCodeExporter commented 9 years ago
Fix is for version 1.3

Original comment by berthold...@gmail.com on 21 Aug 2010 at 6:33

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 24 Aug 2010 at 2:37

GoogleCodeExporter commented 9 years ago
Thank you for the patch.  Please review.

$ svn commit -m "Issue 187 ; applying patch from berthold.daum at bdaum.de, 
adding example that demonstrates issue" .
Transmitting file data ..
Committed revision 1055.

Original comment by heue...@gmail.com on 27 Aug 2010 at 4:47

GoogleCodeExporter commented 9 years ago
Okay.

Original comment by berthold...@gmail.com on 30 Aug 2010 at 12:55

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 30 Aug 2010 at 5:50