search

samrushing / paper_key

standalone bitcoin paper key generator
3 stars 2 forks source link

Zero pad the private key to make 32 bytes [GH-1] #2

Closed markpeek closed 10 years ago

samrushing commented 10 years ago

I saw this 'zero-pad' bug recently, and I think the bitcoin developers screwed it up. The point of a bitcoin address is to be as short as possible. So deliberately adding extra '1' characters to the front of the output is unnecessary and likely to be incorrect (the way they did it, by counting zeroes in the input).

samrushing commented 10 years ago

Ah, partially ignore my previous comment, I assumed you were talking about a related problem with public keys. I'm actually rewriting all the address/key conversion functions right now to support the other key types (like p2sh), but it's not quite ready yet.

Thanks for the patch!