search

samscott89 / serde_qs

Serde support for querystring-style strings
Apache License 2.0
193 stars 68 forks source link

Newer actix-web versions support #19

Closed daddinuz closed 5 years ago

daddinuz commented 5 years ago

As in the title, would be cool to support newer releases of actix-web. The latest release should be v1.0.0-alpha6.

samscott89 commented 5 years ago

Hey.

Thanks for opening the issue. I would happily accept a PR to add compatibility with v1.0 (perhaps under a new feature, to keep 0.x compatibility), but would probably prefer to keep it in an unreleased git branch until it moves out of alpha/beta. Once it releases I could include it, and might write a quick impl myself.

The newer trait actually looks a lot cleaner (abstracting the config part away), so an implementation should be fairly straightforward.

daddinuz commented 5 years ago

Hi @samscott89, finally actix-web v1.0 has been released :rocket:

samscott89 commented 5 years ago

Thank you for doing that. Merged + version bumped.

daddinuz commented 5 years ago

Thank you for your consideration :+1: