search

samscott89 / serde_qs

Serde support for querystring-style strings
Apache License 2.0
193 stars 68 forks source link

feat: non-strict mode replaces invalid UTF-8 #62

Closed Fishrock123 closed 2 years ago

Fishrock123 commented 2 years ago

This change makes non-strict mode percent-decode utf-8 lossily. This means that invalid UTF-8 percent encoded sequences, such as %E9, are decoded as the unicode replacement character (� U+FFFD).

Refs: https://github.com/samscott89/serde_qs/issues/43

Fishrock123 commented 2 years ago

If this overloads strict mode too much I'm willing to go down the rabbit hole of separating out the config.

samscott89 commented 2 years ago

Hey @Fishrock123! Thanks for creating this. I'll try and get a review done this weekend.

Fishrock123 commented 2 years ago

@samscott89 just a reminder

samscott89 commented 2 years ago

Thanks for the reminder @Fishrock123! Sorry for dropping the ball on this, will try and get to it soon