samscott89 / serde_qs

Serde support for querystring-style strings
Apache License 2.0
193 stars 67 forks source link

Documentation gaps #71

Open andrewbaxter opened 1 year ago

andrewbaxter commented 1 year ago

The docs say this support enums, but how are enums supported? I didn't see any information about that in qs either, and (typescript) handles enums quite differently than rust does so I'm not sure it would be a model. Having an example of how they serialize would be very useful.

Additionally, the readme says

serde_urlencoded, which should be preferred over this crate

Why?

Reading that I think this project must have significant issues that make it only worth using when you have this specific use case, but even with this use case I'm not particularly inclined to working around bugs, etc.

andrewbaxter commented 1 year ago

After looking at the tests, it looks like 3 enum modes are supported

How does untagged work? The test has e=true deserialize as a string true instead of bool true which seems like the exact opposite of what one would normally expect.