samsface / godot-steam-api

Godot Steam integration using GDNative.
401 stars 16 forks source link

Mac OS 10.13.6 runtime error #27

Open skuzmin opened 2 years ago

skuzmin commented 2 years ago

Hi and thank you for your library :)

But I have an issue: library gives error on Mac OS 10.13.6

image image image

Unfortunately I can't update OS to the latest version, so could you make it backward compatible with 10.x.x ?

Thank you!

samsface commented 2 years ago

image The error messge is cut off, can you post the full text? @skuzmin

skuzmin commented 2 years ago

sorry, of course

E 0:00:00.363 open_dynamic_library: Can't open dynamic library: /Users/TrueJarod/Documents/Projects/k3/addons/steam_api/libsteamsdk-godot.dylib, error: dlopen(/Users/TrueJarod/Documents/Projects/k3/addons/steam_api/libsteamsdk-godot.dylib, 2): Symbol not found: ____chkstk_darwin Referenced from: /Users/TrueJarod/Documents/Projects/k3/addons/steam_api/libsteamsdk-godot.dylib (which was built for Mac OS X 11.6) Expected in: /usr/lib/libSystem.B.dylib in /Users/TrueJarod/Documents/Projects/k3/addons/steam_api/libsteamsdk-godot.dylib. <C++ Error> Condition "!p_library_handle" is true. Returned: ERR_CANT_OPEN <C++ Source> platform/osx/os_osx.mm:1956 @ open_dynamic_library()

skuzmin commented 2 years ago

@samsface hi, any chance to have fix for that or it's just deadend ? :(

samsface commented 2 years ago

I'll fix this eventually but no time atm. @skuzmin You can try fix this yourself and open a PR. I beleive the issue is we just need to point at the correct MacOS SDK: https://github.com/samsface/godot-steam-api/commit/1de01a88cf6b0c16d11fd2e158a046c523c2c413

skuzmin commented 2 years ago

thx, I will try

samsface commented 2 years ago

Leaving open as problem still exists.

and3rson commented 2 years ago

@samsface thanks for response!

If I understand correctly, 1de01a8 fixes this, but we have to rebuild the lib and submit the PR with the newly recompiled binary itself, correct?

P.S. Thanks for the awesome library, great job!

Update: any additional flags we need to pass to cmake? I've tried building with cmake . -DCMAKE_BUILD_TYPE=Release and the resulting library is 61 MB of size... Anything we're missing?

Update 2: forgot to strip the binary. Now it's 3 megs. :)

samsface commented 2 years ago

@and3rson I believe so. However, have no High Sierra Mac to confirm this.

paskausks commented 10 months ago

Just necroing this to let you know that an update to support the older mac os versions would be highly appreciated!

paskausks commented 9 months ago

@and3rson do you have the built MacOS libraries lying around somewhere, by any chance?

BlooRabbit commented 3 months ago

Hello, fantastic plugin for PC and Linux ! I am running into trouble on Mac, though. Got the same type of "open_dynamic_library: Can't open dynamic library" error as mentioned above. I am using Godot 3.5 on a M1 MacBook Air with Sonoma 14.5. Would be super grateful for any help ! - maybe even a detailed explanation about how to fix stuff yourself ?