samsface / godot-steam-api

Godot Steam integration using GDNative.
402 stars 17 forks source link

Prevent orphan node warnings on export #8

Closed snoopdouglas closed 3 years ago

snoopdouglas commented 3 years ago

When exporting, I'm finding that Godot spits out a lot of warnings saying that steam.gd has been orphaned, a la:

WARNING: cleanup: ObjectDB instances leaked at exit (run with -
-verbose for details).

It appears this can be fixed by changing _exit_tree to disable_plugin in plugin.gd.

samsface commented 3 years ago

Change the cleanup to be in disable_plugin and don't see any warnings anymore :pray:

snoopdouglas commented 3 years ago

Awesome. Fixed in d9143f2fbdf9327556969eb98e0d4fae1bbddeb9