search

samshull / node-proxy

Deprecated: Harmony Proxies in node (no longer needed)
MIT License
162 stars 29 forks source link

Windows build #25

Closed andreasbotsikas closed 12 years ago

andreasbotsikas commented 12 years ago

I have added the binding.gyp file (to build your module using gyp) and have modified the src to add the NODE_MODULE macro (needed to specify the module entry point). Moreover, the native module's name must be the same as the node file in order to load properly on windows.

Hope this helps,

Andreas

samshull commented 12 years ago

This commit breaks on my mac. I don't think the Makefile changes would work anywhere.

andreasbotsikas commented 12 years ago

Hi @samshull. I am sorry to hear that this won't work on Mac. Unfortunately I am a pc user and couldn’t test it on mac. Is there a problem with the cc file not compiling or is it something wrong with the makefile? What I was trying to do is use TooTallNate's node-gyp to do the whole building. This way you can have your module building on all platforms without the need of the Makefile. Please let me know on where the error is so that I can make another pull request removing completly the makefile and wscript

andreasbotsikas commented 12 years ago

I have redone my changes using ifdef preprocessor in my new request at https://github.com/samshull/node-proxy/pull/26